[PATCH] D11776: WebAssembly: textual emission uses expected opcode names

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 6 13:41:55 PDT 2015


majnemer added a subscriber: majnemer.

================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:85
@@ +84,3 @@
+  for (; N[Pos] != '\0' && N[Pos] != '_'; ++Pos)
+    N[Pos] = std::tolower(N[Pos]);
+  return SmallString<32>(&N[0], &N[Pos]);
----------------
sunfish wrote:
> Please avoid std::tolower since it has locale-specific behavior, and compiler output should not be locale-specific.
FYI we have such a function in LLVM, `ascii_tolower`, but it would need to move to a header file.


http://reviews.llvm.org/D11776





More information about the llvm-commits mailing list