[PATCH] D11458: ELF: Add AMDGPU specific defintions

[Rafael Ávila de Espíndola]

rafael added a comment.

Please include a llvm-readobj testcase.


================
Comment at: include/llvm/Support/ELF.h:752
@@ +751,3 @@
+
+  SHF_AMDGPU_HSA_GLOBAL = (0x00100000 & SHF_MASKOS),
+  SHF_AMDGPU_HSA_READONLY = (0x00200000 & SHF_MASKOS),
----------------
Please just include the final value.

================
Comment at: include/llvm/Support/ELF.h:838
@@ +837,3 @@
+
+  // AMDGPU symbol types
+  STT_AMDGPU_HSA_KERNEL = STT_LOOS,
----------------
Please just include the final value.

================
Comment at: include/llvm/Support/ELF.h:995
@@ +994,3 @@
+  // AMDGPU program header types.
+  PT_AMDGPU_HSA_LOAD_GLOBAL_PROGRAM = PT_LOOS,
+  PT_AMDGPU_HSA_LOAD_GLOBAL_AGENT = PT_LOOS + 1,
----------------
Please just include the final value.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:967
@@ +966,3 @@
+    switch(SymbolType) {
+    #define LLVM_READOBJ_AMDGPU_STT_CASE(name) \
+      case name: W.printHex("Type", #name, name); break;
----------------
Can't you add ad

static const EnumEntry<unsigned> AMDGPUSymbolTypes[] = {
...
}
?


http://reviews.llvm.org/D11458