[llvm] r243487 - [tests] Use llvm-readobj instead of macho-dump.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Aug 5 04:49:33 PDT 2015


> Sure. The last beast to tackle is llvm-objdump. I'm cool with doing
> the conversion but I wanted to hear your opinion. I think that
> llvm-readobj is more of a tool for the final user so it makes sense to
> continue on error rather than calling exit(1). What's your opinion,
> and, if you know, what's the GNU behavior in this case?

When creating invalid object files for tests I noticed that tools like
readelf normally print an error/warning and then proceed to print
garbage or crash.

IMHO users are better served by a good error message and a full stop,
so IMHO exit(1) is better for llvm-objdump too.

Cheers,
Rafael


More information about the llvm-commits mailing list