[PATCH] D11484: [compiler] [tsan] Enable tsan for aarch64

Dmitry Vyukov dvyukov at google.com
Tue Aug 4 07:12:53 PDT 2015


dvyukov added a comment.

Please reupload the change with full context, obtain the diff with:
$ svn diff --diff-cmd=diff -x -U999999


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:198
@@ -197,1 +197,3 @@
+// all current supported platforms have 16 bytes stack alignment
+# define STACK_ALIGN 16
   typedef void (*get_tls_func)(size_t*, size_t*) DL_INTERNAL_FUNCTION;
----------------
Please use a constant instead of macro:

  const uptr kStackAlign = 16;


================
Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:212
@@ -209,1 +211,3 @@
+  g_tls_size = RoundUpTo(tls_size, tls_align);
+#endif  // !SANITIZER_FREEBSD && !SANITIZER_ANDROID
 }
----------------
Why did you remove !SANITIZER_GO?


http://reviews.llvm.org/D11484







More information about the llvm-commits mailing list