[PATCH] D11726: [ASan] Add SIGFPE by default as deadly signal

Kostya Serebryany kcc at google.com
Mon Aug 3 11:33:24 PDT 2015


kcc added a comment.

Looks almost good! 
May I ask you to add a lit-style test, probably similar to projects/compiler-rt/test/sanitizer_common/TestCases/Linux/assert.cc?


================
Comment at: lib/asan/tests/asan_test.cc:262
@@ +261,3 @@
+
+__attribute__((optnone))
+void division_by_zero() {
----------------
Just in case, I would use volatile instead of __attribute__((optnone)
e.g.
volatile int one = 1;
volatile int zero = 0;
volatile int sink;
sink = one/zero


http://reviews.llvm.org/D11726







More information about the llvm-commits mailing list