[PATCH] D9751: Add HSAIL target

Matt Arsenault Matthew.Arsenault at amd.com
Fri Jul 31 13:18:04 PDT 2015


On 07/10/2015 01:06 PM, Rafael Ávila de Espíndola wrote:
> Comment at: lib/Target/HSAIL/HSAILSection.cpp:15
> @@ +14,3 @@
> +
> +void HSAILSection::PrintSwitchToSection(const MCAsmInfo &MAI,
> +                                        raw_ostream &OS,
> ----------------
> Just don't create sections instead of having empty section switching.
>
>
> http://reviews.llvm.org/D9751
>
I think I have a solution that works without using the HSAILSection 
hack. I resurrect RegisterAsmStreamer and implement a custom 
MCAsmStreamer that overrides the small subset of functionality we 
support and doesn't call SwitchSection. Currently I have to copy-paste 
about 10 overrides from the default MCAsmStreamer. I'll need to put an 
MCBasicAsmStreamer or something like that in a header that I can derive 
from with these overrides. Is something like this an acceptable 
solution? Trying to thread a no switch section flag through the existing 
code seemed like it would make a mess in a lot of places and would be a 
constant burden to consider.

-Matt




More information about the llvm-commits mailing list