[PATCH] D11679: [compiler-rt] Add AArch64 to CMake configuration and several missing builtins

[Sergey Dmitrouk]

sdmitrouk added a comment.

Renato,

> Where have you tested this?


On Qemu, don't have usable AArch64 board.

> Does "make check-all" pass when compiling RT with Clang? That's what the buildbot will do, so it needs to be green.


I should get used to look up build instructions in `www/`, ran tests in a weird way. There are seven failures of existing builtins (by the way, these and one more of tests don't even compile out of the box due to missing include, which is obviously easy to fix):

  compiler-rt :: builtins :: Unit/divxc3_test.c
  compiler-rt :: builtins :: Unit/fixtfsi_test.c
  compiler-rt :: builtins :: Unit/fixunsxfti_test.c
  compiler-rt :: builtins :: Unit/fixxfti_test.c
  compiler-rt :: builtins :: Unit/floattixf_test.c
  compiler-rt :: builtins :: Unit/floatuntixf_test.c
  compiler-rt :: builtins :: Unit/multf3_test.c

So looks like adding AArch64 target is too early. Does it still makes sense to add missing builtins without updating configuration? It's not that easy to fix broken functions of this kind and I can't promise to do it soon, I wonder if these are actually used by someone at the moment.

Thanks,
Sergey


Repository:
  rL LLVM

http://reviews.llvm.org/D11679