[RFC] SortedVector ADT

Puyan Lotfi puyan at puyan.org
Fri Jul 31 09:48:51 PDT 2015


On Fri, Jul 31, 2015 at 9:44 AM, Krzysztof Parzyszek <
kparzysz at codeaurora.org> wrote:

> On 7/31/2015 8:27 AM, Aaron Ballman wrote:
>
>>
>> I am wondering why this should be an ADT instead of one-off
>> functionality. I see that you're going to use it for
>> MachineBasicBlock, but are there other use cases as well? The kind of
>> functionality that this class provides is covered by basic STL
>> mechanisms, and so I am hesitant to support it as an ADT for all of
>> our users unless this is something we expect will be heavily used (or
>> is heavily customized to support toolchain needs).
>>
>
> I agree.  Also, I think we should avoid creating new ADT unless there is a
> compelling reason to have our own implementation of a container.
>
>
Does this mean we should also try to remove any existing ADTs that aren't
as compelling to have anymore?


> -Krzysztof
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150731/d404b8d3/attachment.html>


More information about the llvm-commits mailing list