[PATCH] D11679: [compiler-rt] Add AArch64 to CMake configuration and several missing builtins

Sergey Dmitrouk sdmitrouk at accesssoftek.com
Fri Jul 31 07:34:34 PDT 2015


sdmitrouk created this revision.
sdmitrouk added reviewers: howard.hinnant, rengolin.
sdmitrouk added subscribers: llvm-commits, samsonov, emaste.
sdmitrouk set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.

Currently CMake doesn't build builtins for AArch64 and if one does this anyway
it's likely that at least `__multc3`, `__floatditf` and `__floatunditf` will be
missing.  There is actually more builtins to add, but these come from
different libc implementations, thus providing them makes compiler-rt for
AArch64 good enough at least for basic usage.

Builtins implementation were originally taken from FreeBSD project:

 * [[ https://reviews.freebsd.org/D2173 | __multc3 ]]
 * [[ https://reviews.freebsd.org/D2174 | __floatditf and __floatunditf ]]

Until they have been tested to find mistakes in `__float*` functions.
`__floatditf` was based on `__floatsitf`, which had the same mistakes
(fixed it in r243746).

Version of the builtins in this patch are fixed and complemented with basic
tests.  Additionally they were tested via GCC's torture (this is what revealed
these issues).

P.S. Ed (author of FreeBSD patches) asked for feedback on the list some time ago (here [[ http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-March/084064.html | here ]])
and got no response, but it seems to be worth adding these builtins as is and
extracting common part later.

Repository:
  rL LLVM

http://reviews.llvm.org/D11679

Files:
  lib/builtins/CMakeLists.txt
  lib/builtins/floatditf.c
  lib/builtins/floatunditf.c
  lib/builtins/multc3.c
  test/builtins/Unit/floatditf_test.c
  test/builtins/Unit/floatunditf_test.c
  test/builtins/Unit/multc3_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11679.31119.patch
Type: text/x-patch
Size: 12132 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150731/089926a0/attachment.bin>


More information about the llvm-commits mailing list