[compiler-rt] r243686 - [Sanitizers] [Bug 24151] Generalize type of offset in internal_mmap

[Daniel Sanders]

Reverting this patch didn't make the builder green so it must either be one of the others or an environment issue. I've re-committed it.

I'm planning to test rc2 with r243686, and r243745 applied locally. Let me know if you'd prefer me to test rc2 without them.

> -----Original Message-----
> From: Daniel Sanders
> Sent: 31 July 2015 10:01
> To: 'Hans Wennborg'; Mohit Bhakkad; kcc at google.com
> Cc: llvm-commits
> Subject: RE: [compiler-rt] r243686 - [Sanitizers] [Bug 24151] Generalize type
> of offset in internal_mmap
> 
> I don't think it's related but it's not a false positive either. The annotate step
> is failing with:
> 	/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-
> fast/build/llvm/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:264:
> 38: error: no member named 'Mode64Bit' in namespace 'llvm::X86'
> 	    return STI.getFeatureBits()[X86::Mode64Bit];
> 	                                ~~~~~^
> and other compilation errors in areas this patch didn't touch.
> 
> I don't see another likely candidate in the blamelist though so I'll revert and
> see if it turns green.
> 
> > -----Original Message-----
> > From: hwennborg at google.com [mailto:hwennborg at google.com] On
> Behalf
> > Of Hans Wennborg
> > Sent: 31 July 2015 00:14
> > To: Daniel Sanders
> > Cc: llvm-commits
> > Subject: Re: [compiler-rt] r243686 - [Sanitizers] [Bug 24151] Generalize type
> > of offset in internal_mmap
> >
> > On Thu, Jul 30, 2015 at 2:00 PM, Daniel Sanders
> > <daniel.sanders at imgtec.com> wrote:
> > > Author: dsanders
> > > Date: Thu Jul 30 16:00:48 2015
> > > New Revision: 243686
> > >
> > > URL: http://llvm.org/viewvc/llvm-project?rev=243686&view=rev
> > > Log:
> > > [Sanitizers] [Bug 24151] Generalize type of offset in internal_mmap
> > >
> > > Summary:
> > > Using u64 as type for offset changes its value, changing starting address
> for
> > map in file.
> > > This patch solves Bug 24151, which raises issue while mapping file in
> mips32.
> > >
> > > Patch by Mohit Bhakkad
> > >
> > > Reviewers: dsanders, kcc
> > >
> > > Subscribers: hans, llvm-commits, samsonov, nitesh.jain, sagar, bhushan,
> > jaydeep
> > >
> > > Differential Revision: http://reviews.llvm.org/D11588
> >
> > It might not be related (I'm not entirely sure what's going on), but
> > it seems this change made a bot go red:
> > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5935
> >
> > Given that, I'm not going to try and squeeze this into 3.7 right before RC2.