[PATCH] D11548: [LLVM] Fix Clang-tidy llvm-namespace-comment warnings

[Alexander Kornienko]

Apparently, the check is not completely aligned with the preferences of the
community. The relevant rule in the LLVM Coding Standards
<http://llvm.org/docs/CodingStandards.html#namespace-indentation> doesn't
mandate the use of the namespace ending comments and it uses a slightly
different wording for them ("end namespace xxx" or "end anonymous
namespace"). There's also no recommended minimum namespace size, after
which the comments should be used. Thus the check first needs to be updated
according with the coding standards and community preferences (and maybe
the relevant rule of the coding standards should be made a bit more
specific, so that it's possible to implement in the check).

I already submitted a cleanup patch for this check once (r240270), but had
to revert it later due to the reasons above.

On Tue, Jul 28, 2015 at 10:17 PM, Eugene Zelenko <eugene.zelenko at gmail.com>
wrote:

> Eugene.Zelenko added a comment.
>
> I think it's better to place comments consistently independently from
> number of declarations in namespace.
>
> At least Clang-tidy llvm-namespace-comment will be happy and will not
> complain on same part of code in future.
>
>
> http://reviews.llvm.org/D11548
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150731/c762380f/attachment.html>