[PATCH] D11602: AMDGPU/SI: Use ComplexPatterns for SMRD addressing modes

Matt Arsenault Matthew.Arsenault at amd.com
Thu Jul 30 18:28:53 PDT 2015


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1165-1166
@@ +1164,4 @@
+///
+/// \param EncodedOffset This is the immediate value that will be encoded
+///        directly into the instruction.
+static bool isLegalSMRDImmOffset(const AMDGPUSubtarget *ST,
----------------
I would add another sentence "Note that the offset has different units on VI" or something like that


http://reviews.llvm.org/D11602







More information about the llvm-commits mailing list