[PATCH] D11655: COFF: Sort output sections which start with .debug to the end of the file

Rui Ueyama ruiu at google.com
Thu Jul 30 13:16:42 PDT 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: COFF/Writer.cpp:401
@@ -400,1 +400,3 @@
   uint64_t FileOff = SizeOfHeaders;
+  std::stable_partition(
+      OutputSections.begin(), OutputSections.end(), [](OutputSection *S) {
----------------
Please add a comment saying that the code is to move DISCARDABLE (or non-memory-mapped) sections to the end of file because the loader cannnot handle holes.


http://reviews.llvm.org/D11655







More information about the llvm-commits mailing list