D11610: [mips][FastISel] Remove hidden mips-fast-isel option.

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Jul 30 09:22:50 PDT 2015


Thanks. I was just about to merge these :-).

> -----Original Message-----
> From: hwennborg at google.com [mailto:hwennborg at google.com] On Behalf
> Of Hans Wennborg
> Sent: 30 July 2015 17:20
> To: Vasileios Kalintiris
> Cc: qcolombet at apple.com; llvm-commits at cs.uiuc.edu;
> ehostunreach at gmail.com; Daniel Sanders
> Subject: Re: D11610: [mips][FastISel] Remove hidden mips-fast-isel option.
> 
> Merged to 3.7:
> 
> r243469 in r243646.
> r243485 in r243647.
> r243636 (that's D11592) in r243648.
> r243638 (that's this code-review, D11610) and r243640 (follow-up) in r243650.
> 
> Cheers,
> Hans
> 
> On Wed, Jul 29, 2015 at 3:04 PM, Vasileios Kalintiris
> <Vasileios.Kalintiris at imgtec.com> wrote:
> > Thank you Han, that's perfect. CC-ing Daniel too... I think I need some
> coffee :)
> > ________________________________________
> > From: hwennborg at google.com [hwennborg at google.com] on behalf of
> Hans Wennborg [hans at chromium.org]
> > Sent: 29 July 2015 23:00
> > To: Vasileios Kalintiris
> > Cc: qcolombet at apple.com; llvm-commits at cs.uiuc.edu;
> ehostunreach at gmail.com
> > Subject: Re: D11610: [mips][FastISel] Remove hidden mips-fast-isel option.
> >
> > Sounds great. Let me know when this and D11592 lands and we can get it
> > all merged.
> >
> > Thanks,
> > Hans
> >
> > On Wed, Jul 29, 2015 at 2:55 PM, Vasileios Kalintiris
> > <Vasileios.Kalintiris at imgtec.com> wrote:
> >> Sorry for the double mail. I forgot to actually include Han's e-mail.
> >>
> >> ________________________________________
> >> From: Vasileios Kalintiris
> >> Sent: 29 July 2015 22:51
> >> To: Craig Hansen-Sturm
> >> Cc: qcolombet at apple.com; llvm-commits at cs.uiuc.edu;
> ehostunreach at gmail.com
> >> Subject: RE: D11610: [mips][FastISel] Remove hidden mips-fast-isel
> option.
> >>
> >> Hello Hans,
> >>
> >> With this review request and the following bug-fixes
> >>
> >> 1) r243485: [mips][FastISel] Fix call lowering by bailing out on "fastcc" calls.
> >> 2) r243469: [mips][FastISel] Fix generated code for IR's select instruction.
> >> 3) [mips][FastISel] Apply only zero-extension to constants prior to their
> materialization. (http://reviews.llvm.org/D11592 pending LGTM from Daniel)
> >>
> >> We are able to bootstrap Clang with FastISel and pass every test from the
> LLVM test-suite under various and different configurations. Although, we are
> almost at the end of the RC2 phase, these patches have been tested
> thoroughly throughout the last 2+ weeks and it would be nice to consider
> them for the RC branch. I've CC'ed Daniel Sanders if you have any question or
> need clarification about something.
> >>
> >> Thanks,
> >> Vasileios Kalintiris




More information about the llvm-commits mailing list