[PATCH] D11635: DebugInfo: Emit DW_AT_address_class for non-0 address space

David Blaikie dblaikie at gmail.com
Thu Jul 30 04:55:49 PDT 2015


Hey Duncan - what's this "extraData" field intended for? Is this a
reasonable use of it?

I imagine we just want to extend the schema here to explicitly include
address space?

Could we instead extract it from the value we're describing? (probably not?
if the address happens to be a constant or something (which I guess is more
likely in custom address spaces) it wouldn't be carrying explicit address
space info?)

On Thu, Jul 30, 2015 at 12:33 AM, Matt Arsenault <Matthew.Arsenault at amd.com>
wrote:

> arsenm created this revision.
> arsenm added a reviewer: echristo.
> arsenm added a subscriber: llvm-commits.
>
> http://reviews.llvm.org/D11635
>
> Files:
>   include/llvm/IR/DIBuilder.h
>   include/llvm/IR/DebugInfoMetadata.h
>   lib/CodeGen/AsmPrinter/DwarfUnit.cpp
>   lib/IR/DIBuilder.cpp
>   test/DebugInfo/AMDGPU/DW_AT_address_class.ll
>   test/DebugInfo/AMDGPU/lit.local.cfg
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150730/7692d225/attachment.html>


More information about the llvm-commits mailing list