[PATCH] D11363: Allow merging of immediates within a basic block for code size savings and reduced footprint.

Quentin Colombet qcolombet at apple.com
Wed Jul 29 09:46:44 PDT 2015


qcolombet added a comment.

Hi Michael,

I am not sure I understand this part:

> We sill still pull the constant into the instruction during selection.


I thought ConstantHoisting was marking the constants as opaque so that this cannot happen. What am I missing?

>   [...] but the instruction selection changes are needed regardless of that.


Which ones are needed?

Thanks,
-Quentin


http://reviews.llvm.org/D11363







More information about the llvm-commits mailing list