[PATCH] D11577: Reassociate: Implement isUnmovableInstruction() without a hardcoded list

[David Majnemer]

majnemer added inline comments.

================
Comment at: lib/Transforms/Scalar/Reassociate.cpp:278
@@ -297,3 +277,3 @@
     for (BasicBlock::iterator I = BB->begin(), E = BB->end(); I != E; ++I)
-      if (isUnmovableInstruction(I))
+      if (I->mayReadOrWriteMemory() || !isSafeToSpeculativelyExecute(I))
         ValueRankMap[&*I] = ++BBRank;
----------------
Would it make sense to extract this logic into a hypothetical `mayBeControlDependent` ?


Repository:
  rL LLVM

http://reviews.llvm.org/D11577