[PATCH] D8304: Fix backward operands in call to isTruncateFree() and improve comments.

Steve King kingshizzle at gmail.com
Tue Jul 28 13:39:48 PDT 2015


srking marked 3 inline comments as done.

================
Comment at: include/llvm/Target/TargetLowering.h:1561-1562
@@ -1559,6 +1560,4 @@
   /// This does not necessarily include registers defined in unknown ways, such
   /// as incoming arguments, or copies from unknown virtual registers. Also, if
-  /// isTruncateFree(Ty2, Ty1) is true, this does not necessarily apply to
-  /// truncate instructions. e.g. on x86-64, all instructions that define 32-bit
-  /// values implicit zero-extend the result out to 64 bits.
-  virtual bool isZExtFree(Type * /*Ty1*/, Type * /*Ty2*/) const {
+  /// isTruncateFree(FromTy, ToTy) is true, this does not necessarily apply to
+  /// truncate instructions, e.g. on x86_64, all instructions that define 32-bit
----------------
jroelofs wrote:
> Now that I've read it again, I don't get what it's trying to say either... I can kind of see it making sense if the operands were accidentally swapped.
Ya, I tried for a while to assimilate this one.  Confusing comments are often worse than nothing.  If you aprove, I will update the patch to delete this comment.


http://reviews.llvm.org/D8304







More information about the llvm-commits mailing list