[PATCH] D9744: Install libunwind headers

[Oleg Ranevskyy]

iid_iunknown added a comment.

Saleem, Logan,

Thank you for your remarks.

Having considered the possibility to unify unwind.h from clang and libunwind, I encountered some differences in the headers making the unification a bit obscure to me. I would greatly appreciate if you could take a look and clarify.

Libunwind has different declarations for ARM EHABI. E.g., there are different _Unwind_Exception structures, __personality_routine function signatures, libunwind also defines some additional constants for ARM EHABI. If these differences are to be reflected in the unified header, the header will need to see the libunwind's _LIBUNWIND_ARM_EHABI macro. This will result in includes cross-dependency between clang and libunwind. Another way is to define own version of _LIBUNWIND_ARM_EHABI in the clang's unwind.h, but this does not look nice either.

My another concern is that, if I get it right, libunwind should work properly with any unwind.h. This might be the clang's unwind.h or, for example, the one from savannah. Similarly to the clang's unwind.h, the savannah's unwind.h does not have different / additional declarations for ARM EHABI that the libunwind needs. Hence use of the libunwind with the unwind.h from savannah is not possible. Would you clarify if there are any plans to support such a possibility, please?

Thank you.


Repository:
  rL LLVM

http://reviews.llvm.org/D9744