[PATCH] D11554: Keep track of ScopArrayInfo objects that model PHI node storage

[Tobias Grosser]

grosser added a comment.

I addressed all your remarks, except:

> Why not use a bool in the pair but introduce this 1/0 integer?


Because there is currently no DenseMapInfo available for bool and it is not 100% clear for me how to add this. However, I realized that I can even with char write just use IsPHI instead of IsPHI ? 1: 0. It would good to add such an implementation (which is super small), but I am not sure how to add thumbstones, empty keys and two boolean values, if only a bool can
be returned as key. As an implementation based on 'char' has almost the same properties, I did not spend more time to look into this.

Thanks again for your review,
Best Tobias


Repository:
  rL LLVM

http://reviews.llvm.org/D11554