[PATCH] D11537: WebAssembly: minor MCAsmInfo fixes

Dan Gohman dan433584 at gmail.com
Mon Jul 27 14:28:17 PDT 2015


sunfish added inline comments.

================
Comment at: llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp:31
@@ +30,3 @@
+  // WebAssembly's text format uses s-expressions to represent its AST,
+  // LISP-style comments are therefore suitable.
+  CommentString = ";";
----------------
I'm ok using ';', but I suggest this comment just say something like "The s-expression format of WebAssembly uses LISP-style comments" since there may be other text formats, and since design justifications belong on the WebAssembly side rather than the LLVM side.

================
Comment at: llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp:38
@@ +37,3 @@
+  InlineAsmStart = ";APP\n";
+  InlineAsmEnd = ";NO_APP\n";
+
----------------
It looks like asm strings are by default printed with emitRawComment which includes the comment character and newline. Do we need to override the defaults for these strings?


Repository:
  rL LLVM

http://reviews.llvm.org/D11537







More information about the llvm-commits mailing list