[llvm] r242945 - IPO: Avoid brace initialization of a map, some versions of libc++ don't like it

Duncan P. N. Exon Smith dexonsmith at apple.com
Mon Jul 27 11:08:01 PDT 2015


> On 2015-Jul-27, at 11:04, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
>> 
>> On 2015-Jul-22, at 14:41, Justin Bogner <mail at justinbogner.com> wrote:
>> 
>> Author: bogner
>> Date: Wed Jul 22 16:41:12 2015
>> New Revision: 242945
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=242945&view=rev
>> Log:
>> IPO: Avoid brace initialization of a map, some versions of libc++ don't like it
>> 
>> Should fix the build failure on these darwin bots:
>> 
>> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_build/12427/
>> http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/10389/
>> 
>> Modified:
>>   llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp
>> 
>> Modified: llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp?rev=242945&r1=242944&r2=242945&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp (original)
>> +++ llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp Wed Jul 22 16:41:12 2015
>> @@ -2000,6 +2000,9 @@ struct MutatedGlobal {
>>  GlobalVariable *GV;
>>  Constant *Initializer;
>>  StoreMap Pending;
>> +
>> +public:
> 
> Is the `public:` necessary/useful here?  (Looks like it might
> already be public...)

Nevermind, looks like this all got reverted anyway... sorry for the noise.



More information about the llvm-commits mailing list