[PATCH] D11166: WIP: Make MergeConsecutiveStores look at other stores on same chain

hfinkel at anl.gov hfinkel at anl.gov
Sun Jul 26 06:30:04 PDT 2015

hfinkel added a comment.

Looking for stores sharing the same chain for merging seems like the right thing to do. This is what you should get from memcpy legalization, etc. anyway.

Shouldn't, however, this be part of the visitor loop below that walks the chain instead of only searching the top (or bottom, depending on how you look at it) store?

Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10788
@@ +10787,3 @@
+    // alias.
+    // TODO: This should be the common (only?) case if combiner-aa is
+    // enabled. Should we skip or remove the code looking at consecutive chains?
Why? Expanding memcpy, etc. also creates these kinds of parallel stores.


More information about the llvm-commits mailing list