[llvm] r243146 - Add const to some Type* parameters which didn't need to be mutable. NFC.

[Pete Cooper]

> On Jul 25, 2015, at 9:20 AM, Craig Topper <craig.topper at gmail.com> wrote:
> 
> I thought we prefered not to put const on Types.
I didn’t know that.  Thanks for the tip.  

I did a quick search of LLVM and there’s 44 hits for ‘const Type *’.  I’m sure if I searched without the const there would be 1000’s of hits so looks like we’re reasonably consistent about leaving out the const.  I’ll revert this when i’m next at a recent checkout to do so.
> They don't have any non-const methods anyway do they?
Only one (PointerType *getPointerTo(unsigned AddrSpace = 0);) and I don’t think it needs to be non-const.  I’ll also see if i can fix that.  I think its only non-const because PointerType::get takes a non-const Type*.

Cheers,
Pete
> 
> On Fri, Jul 24, 2015 at 12:19 PM, Pete Cooper <peter_cooper at apple.com <mailto:peter_cooper at apple.com>> wrote:
> Author: pete
> Date: Fri Jul 24 14:19:26 2015
> New Revision: 243146
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=243146&view=rev <http://llvm.org/viewvc/llvm-project?rev=243146&view=rev>
> Log:
> Add const to some Type* parameters which didn't need to be mutable.  NFC.
> 
> We were only getting the size of the type which doesn't need to modify
> the type.
> 
> Modified:
>     llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=243146&r1=243145&r2=243146&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=243146&r1=243145&r2=243146&view=diff>
> ==============================================================================
> --- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Fri Jul 24 14:19:26 2015
> @@ -925,22 +925,22 @@ PPCTargetLowering::PPCTargetLowering(con
> 
>  /// getMaxByValAlign - Helper for getByValTypeAlignment to determine
>  /// the desired ByVal argument alignment.
> -static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign,
> +static void getMaxByValAlign(const Type *Ty, unsigned &MaxAlign,
>                               unsigned MaxMaxAlign) {
>    if (MaxAlign == MaxMaxAlign)
>      return;
> -  if (VectorType *VTy = dyn_cast<VectorType>(Ty)) {
> +  if (const VectorType *VTy = dyn_cast<VectorType>(Ty)) {
>      if (MaxMaxAlign >= 32 && VTy->getBitWidth() >= 256)
>        MaxAlign = 32;
>      else if (VTy->getBitWidth() >= 128 && MaxAlign < 16)
>        MaxAlign = 16;
> -  } else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
> +  } else if (const ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
>      unsigned EltAlign = 0;
>      getMaxByValAlign(ATy->getElementType(), EltAlign, MaxMaxAlign);
>      if (EltAlign > MaxAlign)
>        MaxAlign = EltAlign;
> -  } else if (StructType *STy = dyn_cast<StructType>(Ty)) {
> -    for (auto *EltTy : STy->elements()) {
> +  } else if (const StructType *STy = dyn_cast<StructType>(Ty)) {
> +    for (const auto *EltTy : STy->elements()) {
>        unsigned EltAlign = 0;
>        getMaxByValAlign(EltTy, EltAlign, MaxMaxAlign);
>        if (EltAlign > MaxAlign)
> 
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=243146&r1=243145&r2=243146&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=243146&r1=243145&r2=243146&view=diff>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Jul 24 14:19:26 2015
> @@ -1806,19 +1806,19 @@ EVT X86TargetLowering::getSetCCResultTyp
> 
>  /// Helper for getByValTypeAlignment to determine
>  /// the desired ByVal argument alignment.
> -static void getMaxByValAlign(Type *Ty, unsigned &MaxAlign) {
> +static void getMaxByValAlign(const Type *Ty, unsigned &MaxAlign) {
>    if (MaxAlign == 16)
>      return;
> -  if (VectorType *VTy = dyn_cast<VectorType>(Ty)) {
> +  if (const VectorType *VTy = dyn_cast<VectorType>(Ty)) {
>      if (VTy->getBitWidth() == 128)
>        MaxAlign = 16;
> -  } else if (ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
> +  } else if (const ArrayType *ATy = dyn_cast<ArrayType>(Ty)) {
>      unsigned EltAlign = 0;
>      getMaxByValAlign(ATy->getElementType(), EltAlign);
>      if (EltAlign > MaxAlign)
>        MaxAlign = EltAlign;
> -  } else if (StructType *STy = dyn_cast<StructType>(Ty)) {
> -    for (auto *EltTy : STy->elements()) {
> +  } else if (const StructType *STy = dyn_cast<StructType>(Ty)) {
> +    for (const auto *EltTy : STy->elements()) {
>        unsigned EltAlign = 0;
>        getMaxByValAlign(EltTy, EltAlign);
>        if (EltAlign > MaxAlign)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
> 
> 
> 
> -- 
> ~Craig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150725/f79e4682/attachment.html>