[PATCH] D11492: DarwinAsmParser: Warn on multiple/mismatching version_min directives

Steven Wu stevenwu at apple.com
Fri Jul 24 15:03:33 PDT 2015

steven_wu added a comment.

In http://reviews.llvm.org/D11492#211737, @MatzeB wrote:

> In http://reviews.llvm.org/D11492#211728, @steven_wu wrote:
> > I am not sure if we should warn for UnknownOS. I guess there can be argument both way but we should at least have a test case for it. I am also not sure if you can run i386 asm parser when x86 backend is not built.
> The "Triple::OSType ExpectedOS = Triple::UnknownOS;" initialization is only there to avoid uninitialized variable warnings, in practice you will always hit one of the switch cases below it.

I was actually referring to what if T.getOS() is UnknownOS. With some more thought, I realize version_min directive will not even parse with -triple armv7-apple. The only case might be interesting is what about armv7-apple-darwin?



More information about the llvm-commits mailing list