[PATCH] D11363: Allow merging of immediates within a basic block for code size savings and reduced footprint.

Zia Ansari zia.ansari at intel.com
Fri Jul 24 14:19:33 PDT 2015


zansari updated this revision to Diff 30606.
zansari added a comment.

Thanks, Sanjay.

I've addressed all of your comment (I hope).

Regarding your question.. At first, I wasn't entirely sure myself, but some testing seemed to indicate that MinSize implies OptForSize. I'm not sure if this is true under all conditions, or not, but I added an extra check to explicitly check for MinSize, just to be on the safe side.

Thanks,
Zia.


http://reviews.llvm.org/D11363

Files:
  lib/Target/X86/X86ISelDAGToDAG.cpp
  lib/Target/X86/X86InstrArithmetic.td
  lib/Target/X86/X86InstrInfo.td
  test/CodeGen/X86/immediate_merging.ll
  test/CodeGen/X86/remat-invalid-liveness.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D11363.30606.patch
Type: text/x-patch
Size: 13335 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150724/348ae194/attachment.bin>


More information about the llvm-commits mailing list