[PATCH] D10717: Enhance loop rotation with existence of profile data in MachineBlockPlacement pass.

David davidxl at google.com
Fri Jul 24 13:46:42 PDT 2015

davidxl added inline comments.

Comment at: lib/CodeGen/MachineBlockPlacement.cpp:84-86
@@ -83,1 +83,5 @@
+static cl::opt<bool> UseProfileBasedCostAnalysis(
+    "use-profile-based-cost-analysis",
+    cl::desc("Use profile data to guide machine block placement."),
+    cl::init(false), cl::Hidden);
chandlerc wrote:
> This seems confusing to me. We use profile data to guide many parts of block placement. This flag doesn't guard most of them. Could you select a more accurate name?
yes -- something like 

'precise-rotation-cost' would be clearer. 


More information about the llvm-commits mailing list