[PATCH] D11393: [X86] Allow X86::COND_NE_OR_P and X86::COND_NP_OR_E to be reversed.

David davidxl at google.com
Fri Jul 24 13:18:33 PDT 2015


davidxl added inline comments.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:3545
@@ +3544,3 @@
+              BranchCode == X86::COND_E))
+      BranchCode = X86::COND_P_AND_NE;
+    else if ((OldBranchCode == X86::COND_NP &&
----------------
I might have missed other discussions (so that I completely missed with COND_P_AND_NE means), but should (NE || NP) be equivalent to !(E && P) which means the branch code should be the negate of COND_P_AND_E? 
Similarly, (P||E) should be negate of NE_AND_NP?


http://reviews.llvm.org/D11393







More information about the llvm-commits mailing list