[PATCH] D11445: [zorg] Add lldb build factory that launches scripts on slave machine
chying at google.com
Fri Jul 24 12:05:47 PDT 2015
chying added inline comments.
Comment at: zorg/buildbot/builders/LLDBBuilder.py:926
@@ +925,3 @@
+ # Get lldb-server binaries
+ if not buildAndroid:
> chying wrote:
> > chaoren wrote:
> > > We don't need this until we start testing. Could you move this between build and test?
> > I was thinking if this revision of binaries doesn't exist, then the build will terminate from here.
> > This might happen when the build is not triggered by buildserver, like when user click Force Build from webpage.
> > like when user click Force Build from webpage
> In that case shouldn't we just fetch the most recent lldb-server?
Yes, when user click Force Build, it should fetch most recent revision.
But it depends on buildserver to create lldb-server binaries.
It is possible bulidserver hasn't finished build with the most recent revision.
More information about the llvm-commits