[PATCH] D11474: Add an overload of LoadedObjectInfo::getSectionLoadAddress.

Lang Hames lhames at gmail.com
Thu Jul 23 13:35:30 PDT 2015


lhames added a comment.

Hi Eugene,

Thanks for re-submitting this via Phab.

The direction is good, but this highlights a deficiency in the current code that will require a bit more work to fix: The LocalSections map should really be attached to the LoadedObjectInfo instance, rather than the RuntimeDyldImpl class, as SectionRefs are not globally unique. (Clashes will be rare in practice, but probably very confusing when they crop up).

I'm working on a fix for this right now - I hope to have something for you today or tomorrow.

Cheers,
Lang.


http://reviews.llvm.org/D11474







More information about the llvm-commits mailing list