[PATCH] D11268: [DebugInfo] Fix ARM/AArch64 prologue_end position

Kuba Brecka kuba.brecka at gmail.com
Thu Jul 23 08:06:28 PDT 2015


kubabrecka added inline comments.

================
Comment at: lib/Target/ARM/ARMFrameLowering.cpp:331-332
@@ -326,4 +330,4 @@
   if (ArgRegsSaveSize) {
     emitSPUpdate(isARM, MBB, MBBI, dl, TII, -ArgRegsSaveSize,
                  MachineInstr::FrameSetup);
     DefCFAOffsetCandidates.addInst(std::prev(MBBI), ArgRegsSaveSize, true);
----------------
echristo wrote:
> The DebugLoc for all uses of emitSPUpdate is now just DebugLoc so you can remove the parameter.
Hm, but `emitSPUpdate` is also used from `emitEpilogue` and `eliminateCallFramePseudoInstr`, where some debug location is still used (and it's not relevant to the bug I'm trying to fix, which is wrong `prologue_end` in DWARF).


http://reviews.llvm.org/D11268







More information about the llvm-commits mailing list