[PATCH] D11413: X86: Fixed assertion failure in 32-bit mode

Michael Kuperstein michael.m.kuperstein at intel.com
Thu Jul 23 00:30:37 PDT 2015

mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.


Comment at: lib/Target/X86/X86ISelLowering.cpp:7385
@@ -7385,1 +7384,3 @@
+                                               DAG);
+  if (V2S && DAG.getTargetLoweringInfo().isTypeLegal(V2S.getValueType())) {
     // We need to zext the scalar if it is smaller than an i32.
delena wrote:
> mkuper wrote:
> > This seems a bit odd - if getScalarValueForVectorElement() returned a non-null value, there was already a SCALAR_TO_VECTOR or a BUILD_VECTOR there. So why would forming a SCALAR_TO_VECTOR be wrong?
> > 
> > (I'm not saying it's not, I just don't understand why.)
> The pattern here is  " BITCAST(v2f64 (SCALAR_TO_VECTOR (f64 Val))) to v2i64."
> So, the original "scalar_to_vector" was legal.
Ah, ok, makes sense.



More information about the llvm-commits mailing list