[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

[Filipe Cabecinhas]

On Wed, Jul 22, 2015 at 1:24 PM, Kostya Serebryany <kcc at google.com> wrote:

> kcc added a comment.
>
> Ok. You seem to be serious about this.
> Let us
>
> - Set asan_abort_on_error=(SANITIZER_MAC | ...) as you have it now
> - Update config.environment['ASAN_OPTIONS'] but only under "if OSX"
> - Same for asan_test_main.cc
>
> There will be a tax: please work with filcab to remove
> config.environment['ASAN_OPTIONS'] = 'symbolize_vs_style=false from the
> main path in lit.cfg
> I want it to be done only for those platforms where he needs this to
> happen -- but not by default and not on Linux
>

Sounds good. I can take it out and keep that line private on our side, for
now, conditional on ps4 (or other platforms which default to VS style) as a
target.
Actually… Kuba: Can you remove that default and add a "if <we're targetting
a mac-like platform>: config.environment['ASAN_OPTIONS']
='abort_on_error=true'" when you land this patch?

Thanks,

  Filipe


> ================
> Comment at: test/asan/TestCases/Darwin/abort_on_error-darwin.cc:7
> @@ +6,3 @@
> +// Intentionally don't inherit the default ASAN_OPTIONS.
> +// RUN: ASAN_OPTIONS="" not --crash %run %t 2>&1 | FileCheck %s
> +
> ----------------
> add a line w/o resetting ASAN_OPTIONS. On mac it will exit() because of
> the change in lit.cfg. We want to still test for it so that we don't run
> all tests with abort_on_error.
> Update the comments.
>
> ================
> Comment at: test/asan/TestCases/Linux/abort_on_error-linux.cc:7
> @@ +6,3 @@
> +// Intentionally don't inherit the default ASAN_OPTIONS.
> +// RUN: ASAN_OPTIONS="" not run %t 2>&1 | FileCheck %s
> +
> ----------------
> add a line w/o ASAN_OPTIONS and update the comment.
> We don't want to set ASAN_OPTIONS on Linux in lit.cfg
>
>
> http://reviews.llvm.org/D7203
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150722/31463abb/attachment.html>