Minor YAML enhancement

Alex L arphaman at gmail.com
Wed Jul 22 10:14:05 PDT 2015


Hi Jonathan,
I just posted a review comment for your patch.
I think that for a patch like this it would make sense to look at git-blame
and figure out who implemented YAML IO in LLVM, or who modified it last and
then add them for review.
Thanks,
Alex

2015-07-22 5:18 GMT-07:00 Jonathan Anderson <jonathan.anderson at mun.ca>:

> Good morning,
>
> I’ve posted a patch to http://reviews.llvm.org/D11137
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11137&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DP4suDCk7TfbqjC-82mCv_yJwwCbWSVgcUdQgXlkw2g&s=O728vIvjKfZFkhiE8vQRfLsSLIJPnqAEqZ6xCqmU_8c&e=>
> that adds another constructor to llvm::yaml::Input, passing filename
> information through to the llvm::yaml::Stream for debugging purposes.
> That is, if it fails to parse foo.yaml, it will now report an error
> having occurred at foo.yaml:7:1 rather than YAML:7:1.
>
> I added a reviewer to http://reviews.llvm.org/D11137
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D11137&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DP4suDCk7TfbqjC-82mCv_yJwwCbWSVgcUdQgXlkw2g&s=O728vIvjKfZFkhiE8vQRfLsSLIJPnqAEqZ6xCqmU_8c&e=>
> based on the contents of CODE_OWNERS.txt a little over a week ago, but I
> haven’t heard any more since then. What’s the best way to find a reviewer
> for this change, other than the code ownership route?
>
> Thanks,
> Jonathan Anderson
>
> Assistant Professor
> Electrical and Computer Engineering
> Memorial University of Newfoundland
>
> http://www.engr.mun.ca/~anderson
> <https://urldefense.proofpoint.com/v2/url?u=http-3A__www.engr.mun.ca_-257Eanderson&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=DP4suDCk7TfbqjC-82mCv_yJwwCbWSVgcUdQgXlkw2g&s=QbMZUt-WK0ZSAnj2YYIGD7BKbQeAhIwhNqleJpZk2Xg&e=>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150722/4a17c025/attachment.html>


More information about the llvm-commits mailing list