[llvm] r242558 - MergeFuncs: Transfer the function parameter attributes to the call site

Nick Lewycky nicholas at mxc.ca
Tue Jul 21 23:54:50 PDT 2015


Arnold Schwaighofer wrote:
>
>> On Jul 19, 2015, at 12:03 PM, Nick Lewycky<nicholas at mxc.ca>  wrote:
>> I strongly suspect that if this patch fixed anything, it is working around another bug. That's what I'm worried about. Please revert this patch and fix that other bug instead.
>
> The fix is in r242807.
>
> When replacing direct callers MergeFunctions is inserting a bit cast. If we don’t apply ABI changing attributes from the callee to the call site this information is lost for clients querying paramHasAttr.

Makes sense. Thanks!!




More information about the llvm-commits mailing list