[PATCH] D7203: [asan] Set abort_on_error=1 by default on OS X

[Alexey Samsonov]

samsonov added a comment.

In http://reviews.llvm.org/D7203#209394, @filcab wrote:

> Hi all,
>  Sorry for not replying earlier.
>
> Kostya:
>  It encourages changes if needed, yes.
>  Like when a platform needs to change something related to other platforms
>  where ASan runs, and would require lots of changes to tests.
>
> We also clear away ASAN_OPTIONS (and the others) when we run tests, which
>  allows us to make minimum assumptions when running them. This specific
>  change seems to be strictly on the "positive" side. Without it we could
>  simply fail some tests because the user happened to have a specific option
>  turned on by default and ran the ASan tests.
>
> By having ASAN_OPTIONS be reset by lit, and then having each test that
>  cares about it adding or replacing it, we can test the options themselves,
>  their absence, and have "proper" defaults for the tests.
>  It also allows us to "easily" have platforms specify their own defaults for
>  flags, like what Kuba wants to do.


Could you remind me why we set `ASAN_OPTIONS=symbolize_vs_style=false` in lit config, if we discard
ASAN_OPTIONS from system environment anyway, and `symbolize_vs_style=false` *is* the default?

That is, clearing ASAN_OPTIONS is fine, what worries us is adding default ASAN_OPTIONS for all
tests that would not match the default configuration we're shipping to users.

> About this specific change:

>  It's surprising (to me) to have ASan, by default, exit() the process, as if

>  "no error" had happened (by which I mean: The process exited in a "normal"

>  way, even though it exited with a failure exit code). This doesn't affect

>  me much, as an exit() on my platform is also "weird". But on Mac OS X it

>  feels weird to not have it crash.

> 

> Regards,

> 

>   Filipe





http://reviews.llvm.org/D7203