[PATCH] D11146: [ValueTracking] Add support for floating-point minnum and maxnum

[James Molloy]

Thanks Matt!

While you're here, could I please point you at
http://reviews.llvm.org/D11262 ? Do you have any comments on this?

Cheers,

James

On Mon, 20 Jul 2015 at 21:25 Matt Arsenault <Matthew.Arsenault at amd.com>
wrote:

> arsenm added inline comments.
>
> ================
> Comment at: test/Transforms/InstCombine/minmax-fp.ll:4-5
> @@ +3,4 @@
> +; CHECK-LABEL: @t1
> +; CHECK-NEXT: fcmp
> +; CHECK-NEXT: select
> +; CHECK-NEXT: fpext
> ----------------
> I think these really need to check the operands of these instructions. At
> the very minimum, at least the fcmp compare type.
>
> Besides that LGTM
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D11146
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150721/f2e2311c/attachment.html>