[PATCH] D11389: [asan] Fix the freopen interceptor to allow NULL instead of a filename

Alexander Potapenko glider at google.com
Tue Jul 21 07:16:58 PDT 2015


glider accepted this revision.
glider added a comment.
This revision is now accepted and ready to land.

The case of path==NULL is not covered in the Ubuntu manpage for freopen, but this behavior is mandated by POSIX and is in fact implemented in Glibc.
Therefore LGTM


================
Comment at: test/asan/TestCases/Posix/freopen.cc:10
@@ +9,3 @@
+  freopen(NULL, "a", fp);
+  fclose(fp);
+}
----------------
Please add the return statement.


http://reviews.llvm.org/D11389







More information about the llvm-commits mailing list