[PATCH] D10386: [LAA] Merge memchecks for accesses separated by a constant offset

Adam Nemet anemet at apple.com
Mon Jul 20 21:41:03 PDT 2015

anemet added a comment.

Ah, OK, I think I understand what's going on.

We simply can't have memchecks between pointers of the same underlying objects *unless* shouldRetryWithRuntimeChecks.  I don't think that this what you were trying to explain but if yes, sorry for not understanding.

Anyhow, I think in this case the code is good, we just have to explain the situation in the comment before the UseDependenies check (was this the only reason for the check?).  I.e. why the offending check can only occur with shouldRetryWithRuntimeChecks.

Please also mention shouldRetryWithRuntimeChecks in the testcase you added earlier.  It took me a while to figure out why we wanted to compare pointers with the same underlying object.  (That is kinda the point.)



More information about the llvm-commits mailing list