[PATCH] D11359: [AArch64] Change EON pattern to match more often.

Tim Northover t.p.northover at gmail.com
Mon Jul 20 11:00:27 PDT 2015

t.p.northover added a comment.

The code change seems reasonable -- DAGCombine seems to canonicalise even simple examples to this form. But the tests are a little shaky:

Comment at: test/CodeGen/AArch64/eon.ll:5
@@ +4,3 @@
+define i64 @f(i64 %a, i64 %b, i64 %c) {
+; CHECK: eon
This is almost certainly too weak. It'll grab the f from ".file", and even if it didn't do that it often matches the ".size complex_function_name, .Lcomplex_function_name_end0 - complex_function_name".

I usually find "CHECK-LABEL: f:" works better, colons are far less common in assembly.


More information about the llvm-commits mailing list