[PATCH] D11136: [mips] Added support for the ERETNC instruction.

Daniel Sanders daniel.sanders at imgtec.com
Mon Jul 20 03:11:21 PDT 2015

dsanders added a comment.

Thanks for reviewing this.

Comment at: test/MC/Mips/mips32/valid-xfail.s:38
@@ -37,2 +37,3 @@
         c.un.s          $fcc1,$f30,$f4
+        eretnc
         rorv            $13,$a3,$s5
vkalintiris wrote:
> @dsanders: I believe that we should place this test in invalid-mips32r5.s for pre-R5 ISAs, right? 
Not quite. $isa/valid-xfail.s is for instructions that should be valid on $isa but currently xfail. $isa1/invalid-$isa2.s is for instructions that are valid on $isa1 and invalid on $isa2.

This is valid on MIPS32r5 and invalid on MIPS32 so it belongs in mips32r5/invalid-mips32{,r2,r3}.s


More information about the llvm-commits mailing list