[PATCH] D11289: [X86] Widen the 'AND' mask if doing so shrinks the encoding size

David Majnemer david.majnemer at gmail.com
Fri Jul 17 10:20:10 PDT 2015


majnemer added inline comments.

================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2237
@@ +2236,3 @@
+        // compile time.
+        if ((int8_t)Val < 0) {
+          if (NVT.SimpleTy == MVT::i64)
----------------
escha wrote:
> Is this right? (int8_t)-384 would still pass this check, right?
We wouldn't get that far because it would fail the above `Val > 0` check.


http://reviews.llvm.org/D11289







More information about the llvm-commits mailing list