[PATCH] D11277: [lib/Fuzzer] Add sanitizer runtime errors unit save option

[Karl Skomski]

skomski added a comment.

In http://reviews.llvm.org/D11277#206713, @kcc wrote:

> First question: why is a log file not enough? 
>  It will contain the full sanitizer report (not just summary) and the reproducer. 
>  Frankly, to me this looks like a duplicated functionality.




In http://reviews.llvm.org/D11277#206713, @kcc wrote:

> First question: why is a log file not enough? 
>  It will contain the full sanitizer report (not just summary) and the reproducer. 
>  Frankly, to me this looks like a duplicated functionality.


Can you not say the same thing for the current written timeout- and crash files? I like having the files right away it makes it more convenient.


================
Comment at: lib/Fuzzer/FuzzerLoop.cpp:16
@@ -15,1 +15,3 @@
 
+void __sanitizer_report_error_summary(const char *ErrorSummary) {
+  fuzzer::Fuzzer::StaticErrorReportCallback(ErrorSummary);
----------------
kcc wrote:
> __sanitizer_report_error_summary may be used by other parts of code linked with libSanitizer. 
> Also, summary is just a single line, not sure how it may be useful. 
Is there an alternative to __sanitizer_report_error_summary to receive the runtime error reports? I wanted to use __asan_set_error_report_callback but that doesn't work

> Also, summary is just a single line, not sure how it may be useful.
I wanted to use replicate the original behaviour of __sanitizer_report_error_summary that does  fuzzer::Printf("%s\n", ErrorSummary);


http://reviews.llvm.org/D11277