[PATCH] D11259: Fix OMPT support for task frames for parallel regions and parallel regions + loops

[John Mellor-Crummey]

jmellorcrummey added inline comments.

================
Comment at: runtime/src/kmp_gsupport.c:554
@@ +553,3 @@
+	    // Record that we re-entered the runtime system in the frame that 
+	    // created the parallel region.
+            ompt_frame->reenter_runtime_frame = __builtin_frame_address(0);
----------------
Hahnfeld wrote:
> Indention
The indentation anomalies came from working with vi, which used tabs rather than spaces. I can update the diff if this warrants it.

================
Comment at: runtime/src/kmp_runtime.c:2094
@@ -2089,2 +2093,3 @@
         KMP_DEBUG_ASSERT(master_th->th.th_task_team == parent_team->t.t_task_team[master_th->th.th_task_state]);
+#endif
         KA_TRACE( 20, ( "__kmp_fork_call: Master T#%d pushing task_team %p / team %p, new task_team %p / team %p\n",
----------------
Hahnfeld wrote:
> This probably shouldn't be here, it's part of another issue...
I don't quite know how to handle this. The runtime works though I have test codes that cause the assert to trip. In my development version, I patched out the assert pending patches from Intel. Is leaving in the broken assert preferable? Should I delete the assert entirely and let Intel restore a variant of it later after they have altered the runtime to ensure that the condition is true?


http://reviews.llvm.org/D11259