[PATCH] D11146: [ValueTracking] Add support for floating-point minnum and maxnum

David Majnemer david.majnemer at gmail.com
Thu Jul 16 02:46:24 PDT 2015


majnemer added inline comments.

================
Comment at: lib/Analysis/ValueTracking.cpp:3323
@@ +3322,3 @@
+
+  if (ConstantFP *C = dyn_cast<ConstantFP>(V))
+    return !C->isNaN();
----------------
Use `auto *`, we know the type from the LHS.

================
Comment at: lib/Analysis/ValueTracking.cpp:3329
@@ +3328,3 @@
+static bool isKnownNonZero(Value *V) {
+  if (ConstantFP *C = dyn_cast<ConstantFP>(V))
+    return !C->isZero();
----------------
Ditto.


http://reviews.llvm.org/D11146







More information about the llvm-commits mailing list