[PATCH] D8817: Estimate DCE effect in heuristic for estimating complete-unroll optimization effects.

Chandler Carruth chandlerc at google.com
Wed Jul 15 16:25:05 PDT 2015


I thought this was no longer going forward in favor of the other patches
I've been reviewing...

Michael, leme know if I should still look at this.

On Wed, Jul 15, 2015 at 4:21 PM Gerolf Hoflehner <ghoflehner at apple.com>
wrote:

> Was there an update?
>
> Thanks
> Gerolf
> > On Jul 7, 2015, at 10:28 PM, Michael Zolotukhin <mzolotukhin at apple.com>
> wrote:
> >
> > mzolotukhin marked an inline comment as done.
> >
> > Thanks, Gerolf,
> > I'll update the comments.
> >
> >
> > ================
> > Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:635
> > @@ -620,3 +634,3 @@
> >     // won't find them on later ones too.
> >     if (UnrolledCost == RolledDynamicCost)
> >       return None;
> > ----------------
> > Gerolf wrote:
> >> I'm missing context. Where do the costs get computed?
> > On lines 594, 598.
> >
> >
> > http://reviews.llvm.org/D8817
> >
> >
> >
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150715/499b5a6f/attachment.html>


More information about the llvm-commits mailing list