[PATCH] D8817: Estimate DCE effect in heuristic for estimating complete-unroll optimization effects.

Gerolf Hoflehner ghoflehner at apple.com
Wed Jul 15 16:00:47 PDT 2015


Was there an update?

Thanks
Gerolf
> On Jul 7, 2015, at 10:28 PM, Michael Zolotukhin <mzolotukhin at apple.com> wrote:
> 
> mzolotukhin marked an inline comment as done.
> 
> Thanks, Gerolf,
> I'll update the comments.
> 
> 
> ================
> Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:635
> @@ -620,3 +634,3 @@
>     // won't find them on later ones too.
>     if (UnrolledCost == RolledDynamicCost)
>       return None;
> ----------------
> Gerolf wrote:
>> I'm missing context. Where do the costs get computed?
> On lines 594, 598.
> 
> 
> http://reviews.llvm.org/D8817
> 
> 
> 





More information about the llvm-commits mailing list