[PATCH] D11179: [asan] Invalid debug info for promotable allocas

[Kostya Serebryany]

kcc added inline comments.

================
Comment at: test/Instrumentation/AddressSanitizer/debug_info_noninstrumented_alloca.ll:13
@@ +12,3 @@
+  %instrumented = alloca i32, align 4
+  %non_instrumented = alloca i32, align 4
+  store i32 0, i32* %non_instrumented, align 4
----------------
Please comment why %non_instrumented  will not get instrumented. 

================
Comment at: test/Instrumentation/AddressSanitizer/debug_info_noninstrumented_alloca.ll:21
@@ +20,3 @@
+; CHECK: entry:
+; CHECK: %non_instrumented = alloca i32, align 4
+; CHECK: load i32, i32* @__asan_option_detect_stack_use_after_return
----------------
Please make sure the test works in a non-asserts build. 
I remember there were issues with non-asserts build removing the var names. 


http://reviews.llvm.org/D11179