[PATCH] D11188: [LLD] New ELF implementation

Joerg Sonnenberger joerg at britannica.bec.de
Wed Jul 15 13:35:25 PDT 2015


On Tue, Jul 14, 2015 at 03:12:04PM -0700, Rui Ueyama wrote:
> On Tue, Jul 14, 2015 at 3:07 PM, Joerg Sonnenberger <joerg at netbsd.org>
> wrote:
> 
> > joerg added a subscriber: joerg.
> > joerg added a comment.
> >
> > I don't understand how forcing everything to be grouped can make things
> > more efficient, given that it is strictly required to do more work. It
> > doesn't even matter for plain object files, just for libraries. In the case
> > of libraries, there are subtle error cases involving weak symbols, so
> > please do *not* change the resolution algorithm.
> >
> 
> It's faster because we don't have to visit files grouped by
> --start-group/--end-group repeatedly.

That statement *still* doesn't make sense. Except maybe glibc's libc.so
hack, I see groups rarely used at all. Certainly not for plain object
files and if anything, only implicitly for library archives. So how can
forcing the *additional* work improve things again?

Joerg



More information about the llvm-commits mailing list