[PATCH] D11213: [PM/AA] Disable the core unsafe aspect of GlobalsModRef in the face of basic changes to the IR such as folding pointers through PHIs, Selects, integer casts, store/load pairs, or outlining.

Pete Cooper peter_cooper at apple.com
Wed Jul 15 10:53:42 PDT 2015


pete accepted this revision.
pete added a comment.
This revision is now accepted and ready to land.

LGTM with or without the nitpick.  Thanks!


================
Comment at: lib/Analysis/IPA/GlobalsModRef.cpp:55
@@ +54,3 @@
+// the performance impact of these results.
+static cl::opt<bool> EnableUnsafeGlobalsModRefAliasResults(
+    "enable-unsafe-globalsmodref-alias-results", cl::init(false));
----------------
Nitpicking, but please make this a hidden option so that people are less likely to use it.


http://reviews.llvm.org/D11213







More information about the llvm-commits mailing list